docs: correct the Node.js version base

[yorkie]

Summary

The PR(#13045) converts cli to use esm which also uses named exports for commonjs, this commit just corrects the description in README.

Related Issues/PRs

• cli: convert to ES modules #13045

[yorkie]

See https://twitter.com/MylesBorins/status/1311033983824793601, this is a tweet about named imports from CJS.

[connorjclark]

12.13 (as defined in our package.json) does indeed error.

12.17.0 is earliest version that does not require the experimental modules flag:

https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V12.md#2020-05-26-version-12170-erbium-lts-targos

Can you change the version here + in package.json to be 12.17.0? We'll be moving to Node 14 in ~month for LH v9, but can't do it yet as it would be a breaking change.

[yorkie]

12.13 (as defined in our package.json) does indeed error.

12.17.0 is earliest version that does not require the experimental modules flag:

@connorjclark, thanks for your reply, and it seems here to be 12.20.0 because the named imports are not supported yet at 12.17.0, and I also reproduce the issue at this version at my MBP, and it gets fixed when I used 12.20.0.

BTW the correct versions are >= 12.20 for Node12 and >=14.13 for Node14 via nodejs/node#35249, do you have any suggestion?

[connorjclark]

ah ok, let's list the minimum versions for 12 as 12.20 and 14 as 14.13 in the readme then. (and 12.20 for package.json)

I tried different variations of compound version checks in the engines.node field (and made a .npmrc of engine-strict=true) but npm doesn't seem to support it (and has no docs suggesting they support anything complex) :/ So we're forced to just do >=12.20.0.

EDIT:

actually >=12.20.0 && 12.* || >=14.13 && 14.* || >=15 seems to work in the engine field.

[yorkie]

@connorjclark Updated.

[yorkie]

@connorjclark May I ask you to have a look?

[Mbellsudteen]

ในวันที่ ส. 2 ต.ค. 2021 07:16 น. devtools-bot ***@***.***> เขียนว่า:

…

Merged #13099 <#13099> into master. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#13099 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APZGLUQUPIIRKMYLJNVMID3UEZFMRANCNFSM5ERUHQUA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[Mbellsudteen]

ในวันที่ ส. 2 ต.ค. 2021 07:11 น. Paul Irish ***@***.***> เขียนว่า:

…

***@***.**** approved this pull request. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#13099 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APZGLUSUYKICO5NPZIBEGILUEZEZHANCNFSM5ERUHQUA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.