clients(viewer): use new firebase credentials #13110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
requested review from
patrickhulce
and removed request for
a team
|
App was transfered. |
patrickhulce
approved these changes
Sep 23, 2021
| storageBucket: 'lighthouse-viewer.appspot.com', | ||
| messagingSenderId: '962507201498', | ||
| apiKey: 'AIzaSyBQEZMlX6A9B0jJ6PFGcBADbXZG9ogyCmQ', | ||
| authDomain: 'lighthouse-chrom-1560304954232.firebaseapp.com', |
There was a problem hiding this comment.
it's really lighthouse-chrom not lighthouse-chrome?
There was a problem hiding this comment.
Shrug. It was truncated. This is the correct credentials.
| storageBucket: 'lighthouse-chrom-1560304954232.appspot.com', | ||
| messagingSenderId: '89319782509', | ||
| appId: '1:89319782509:web:9ea5d8e149048c7836e764', | ||
| measurementId: 'G-7FMYHPW5YC', |
There was a problem hiding this comment.
you might need to update the firebase sdk reference in lighthouse-viewer/app/index.html to take advantage of some of these (they're up to v9 now and we're still on v4)
There was a problem hiding this comment.
I've got a follow up PR for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12890
Credentials have been broken for awhile. We lost access to the old project, so I made a new one.
Shouldn't merge this until the Oauth app is transferred out of my name and into
googlechromeorg.