Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clients(psi): include global reports styles in legacy psi rendering #13151

Merged
merged 4 commits into from
Sep 30, 2021

Conversation

paulirish
Copy link
Member

this is minor followup from #13057

the faux-psi was broken https://lighthouse-orr78rw4f-googlechrome.vercel.app/sample-reports/%E2%8C%A3.psi.xl-accented

maintaining preparelabdata is kinda terrible so we'll have to call it quits at some point..

also i tried writing a test, but since jsdom can't apply styles, i can't test much aside from confirming there's a style tag injected. (seems lame)

@paulirish paulirish requested a review from a team as a code owner September 30, 2021 18:52
@paulirish paulirish requested review from adamraine and removed request for a team September 30, 2021 18:52
@google-cla google-cla bot added the cla: yes label Sep 30, 2021
@Mbellsudteen
Copy link

Mbellsudteen commented Oct 2, 2021 via email

@Mbellsudteen
Copy link

Mbellsudteen commented Oct 2, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants