core(fr): timespan ensure bytes transferred #13181
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I was playing around with FR for fun and I ran into an issue with byte efficiency audits.
This time, we were hitting:
lighthouse/lighthouse-core/lib/dependency-graph/simulator/network-analyzer.js
Line 348 in 6c3d609
The first timespan in the flow ("Open search menu") generated ~6 network requests but they all had a
transferSize
of 0 soNetworkAnalyzer
threw this error when creating theLoadSimulator
. The simplest solution was to ensure some bytes were transferred in order to make timespan BE audits applicable.This isn't a problem in navigations, because the main resource guarantees a nonzero total transfer size.