Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(fr): timespan ensure bytes transferred #13181

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

adamraine
Copy link
Member

So I was playing around with FR for fun and I ran into an issue with byte efficiency audits.

This time, we were hitting:

if (!estimatesByOrigin.size) throw new Error('No timing information available');

The first timespan in the flow ("Open search menu") generated ~6 network requests but they all had a transferSize of 0 so NetworkAnalyzer threw this error when creating the LoadSimulator. The simplest solution was to ensure some bytes were transferred in order to make timespan BE audits applicable.

This isn't a problem in navigations, because the main resource guarantees a nonzero total transfer size.

@adamraine adamraine requested a review from a team as a code owner October 6, 2021 20:41
@adamraine adamraine requested review from connorjclark and removed request for a team October 6, 2021 20:41
@google-cla google-cla bot added the cla: yes label Oct 6, 2021
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 nice find!

@patrickhulce patrickhulce merged commit bab68ca into master Oct 6, 2021
@patrickhulce patrickhulce deleted the fr-contentful-records branch October 6, 2021 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants