tests(smoke): make specific assertions about deprecations #13191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
commented
Oct 7, 2021
| items: [ | ||
| { | ||
| value: /Application Cache API manifest/, | ||
| _maxChromiumMilestone: 94, |
There was a problem hiding this comment.
oops, is it 96?
There was a problem hiding this comment.
Looks like 94 is correct: https://www.chromestatus.com/feature/6192449487634432
patrickhulce
reviewed
Oct 7, 2021
| value: /'window.webkitStorageInfo' is deprecated/, | ||
| }, | ||
| { | ||
| value: /Synchronous XMLHttpRequest on the main thread is deprecated/, |
There was a problem hiding this comment.
how is this passing? won't this fail in later milestones because it's at index 1 not 2?
There was a problem hiding this comment.
well currently canary crashes due to unrelated reasons, so I couldn't test it locally.. but you are correct. Added a quick fix to the report asserting that should make this better
adamraine
approved these changes
Oct 8, 2021
| @@ -200,26 +200,42 @@ function pruneExpectations(localConsole, lhr, expected, reportOptions) { | |||
| JSON.stringify(value, null, 2), | |||
| `Actual Chromium version: ${getChromeVersion()}`, | |||
| ].join(' ')); | |||
| delete obj[key]; | |||
| if (Array.isArray(obj)) { | |||
There was a problem hiding this comment.
not feeling DRY is necessary here
| items: [ | ||
| { | ||
| value: /Application Cache API manifest/, | ||
| _maxChromiumMilestone: 94, |
There was a problem hiding this comment.
Looks like 94 is correct: https://www.chromestatus.com/feature/6192449487634432
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed this before seeing #13179... my fix was independent. oops :)
going through with it still because being specific here in the assertions is nice