report(flow): fix report anchors #13233
Merged
+83
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
commented
Oct 20, 2021
| @@ -79,27 +79,27 @@ export function useFlowResult(): LH.FlowResult { | |||
| return flowResult; | |||
| } | |||
|
|
|||
| export function useHashParam(param: string) { | |||
| const [paramValue, setParamValue] = useState(getHashParam(param)); | |||
| export function useHashParams(...params: string[]) { | |||
There was a problem hiding this comment.
Should have been designed this way initially, so changes to multiple hash params are handled in the same render.
paulirish
reviewed
Oct 20, 2021
| @@ -28,27 +28,32 @@ export function convertChildAnchors(element: HTMLElement, index: number) { | |||
|
|
|||
| const nodeId = link.hash.substr(1); | |||
| link.hash = `#index=${index}&anchor=${nodeId}`; | |||
| link.onclick = e => { | |||
There was a problem hiding this comment.
i would expect the new-ish report click handler to end up doing the same thing..
lighthouse/report/renderer/report-renderer.js
Lines 177 to 185 in 362f376
but it doesnt?
There was a problem hiding this comment.
With the flow report, the href of the link is now like #index=0&anchor=seo which isn't a selector anymore.
This would also work if we didn't convert all the link hrefs
connorjclark
approved these changes
Oct 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clicking a score dial, scrolling to the top, then clicking the same score dial doesn't work in the flow report. This is because the URL hash never changes, so it doesn't trigger the flow reports anchors system. This PR uses a normal
onclickhandler for anchor links in the report.#11313