misc(build): use prepack script to build report #13261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
approved these changes
Oct 25, 2021
|
the same is true (wrt |
|
@connorjclark not sure if this worked. I |
|
Shrug. Did I misread the docs? |
|
if you did I did too :) |
kyliau
pushed a commit
to kyliau/lighthouse-stack-packs
that referenced
this pull request
Nov 16, 2021
During npm install, the Lighthouse package which is installed from GitHub (@master branch) triggers the newly added `prepack` script [1], but due to a bug in NPM [2] the devDependencies are not available when the script is run, thus making the installation fail. [1]: GoogleChrome/lighthouse#13261 [2]: npm/cli#1865
kyliau
pushed a commit
to kyliau/lighthouse-stack-packs
that referenced
this pull request
Nov 16, 2021
During npm install, the Lighthouse package which is installed from GitHub (@master branch) triggers the newly added `prepack` script [1], but due to a bug in NPM [2] the devDependencies are not available when the script is run, thus making the installation fail. [1]: GoogleChrome/lighthouse#13261 [2]: npm/cli#1865
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor change.
prepackis run byyarnbeforeyarn pack, and is meant to be used to build things that will be needed in the published package.git/filesystemprotocol: when yarn downloads the specific revision, it packs the package (and thus runsprepack).https://yarnpkg.com/advanced/lifecycle-scripts