report: translate newly added report strings #13308
Merged
+117
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 2, 2021
adamraine
reviewed
Nov 2, 2021
| @@ -417,7 +417,7 @@ export class Util { | |||
| throttling.downloadThroughputKbps === 1.6 * 1024 * 0.9 && | |||
| throttling.uploadThroughputKbps === 750 * 0.9; | |||
| }; | |||
| summary = `${isSlow4G() ? 'Slow 4G' : 'Custom'} throttling by DevTools`; | |||
| summary = isSlow4G() ? Util.i18n.strings.runtimeSlow4g : Util.i18n.strings.runtimeCustom; | |||
There was a problem hiding this comment.
Ah perfect, now I can use this util function directly in #13305!
adamraine
approved these changes
Nov 2, 2021
connorjclark
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
breaking out a few items from #13249 and #13305
(we'll merge this to master separately.. current diff is against #13249)