-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc: preserve error stack when using promise timeout #13333
Conversation
This looks good! While you're here, I think there is one more usage of error timeout that we can upgrade: lighthouse/lighthouse-cli/run.js Lines 175 to 179 in 68ba77a
|
Yeah, true, I was searching across |
All failed checks seem to be unrelated to changes. What are the next actions @adamraine? |
Correct, failed checks are unrelated. #13342 should fix the smoke failure, after that we can land this. |
#13332