Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: move sharding higher so smokehouse-bundle can also shard #13387

Merged
merged 6 commits into from
Nov 30, 2021
Merged

tests: move sharding higher so smokehouse-bundle can also shard #13387

merged 6 commits into from
Nov 30, 2021

Conversation

paulirish
Copy link
Member

companion: cl/410323607

@paulirish paulirish requested a review from a team as a code owner November 17, 2021 01:13
@paulirish paulirish requested review from connorjclark and removed request for a team November 17, 2021 01:13
@google-cla google-cla bot added the cla: yes label Nov 17, 2021
brendankenny
brendankenny approved these changes Nov 18, 2021
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Still can't believe I picked shardArg. Maybe I left it in as a joke but no one objected in the review and now here we are :)

lighthouse-cli/test/smokehouse/smokehouse.js Outdated Show resolved Hide resolved
types/smokehouse.d.ts Show resolved Hide resolved
@devtools-bot devtools-bot merged commit fbb5cc4 into master Nov 30, 2021
@devtools-bot devtools-bot deleted the shardmove branch November 30, 2021 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankenny brendankenny brendankenny approved these changes

@connorjclark connorjclark Awaiting requested review from connorjclark connorjclark was automatically assigned from GoogleChrome/lighthouse-hackers

Assignees

@connorjclark connorjclark

Labels
cla: yes waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulirish @brendankenny @connorjclark @devtools-bot