Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(canonical): remove cross-origin check #13412

Merged
merged 2 commits into from
Nov 23, 2021

Conversation

whitep4nth3r
Copy link
Contributor

Summary

This PR removes the warning regarding canonical URLs being on a different domain, as discussed in #12572.

This warning predates advice given before 2009 and is now no longer relevant.

Related Documentation

The related documentation listed below is collected from the issue linked above:

Related Issues/PRs

Related issue: #12572.

@connorjclark
Copy link
Collaborator

Thanks! You'll need to run yarn update:sample-json to update some files, since a i18n string was removed.

@connorjclark
Copy link
Collaborator

Our CLA bot seems to have gone on vacation. If you don't mind, can you sign this?

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit cla.developers.google.com to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@connorjclark
Copy link
Collaborator

I assume you're in the UK–sorry for the late night requests! I hope to do a Lighthouse release today and having this PR would be great

@connorjclark connorjclark changed the title misc: remove deprecated warning regarding cross-origin canonical URLs core(canonical): remove cross-origin check Nov 23, 2021
@whitep4nth3r
Copy link
Contributor Author

@googlebot I signed it!

@whitep4nth3r
Copy link
Contributor Author

No worries @connorjclark – I'm excited to finally get rid of this warning! 😀

@google-cla google-cla bot added cla: yes and removed cla: no labels Nov 23, 2021
@connorjclark connorjclark merged commit bb89154 into GoogleChrome:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants