deps: remove browserify #13417
Merged
deps: remove browserify #13417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
reviewed
Nov 23, 2021
build/build-lightrider-bundles.js
Outdated
| const rollup = require('rollup'); | ||
| const rollupPlugins = require('./rollup-plugins.js'); | ||
| const fs = require('fs'); | ||
| const path = require('path'); | ||
| const bundleBuilder = require('./build-bundle.js'); | ||
| const {LH_ROOT} = require('../root.js'); | ||
| const inlineFs = require('./plugins/browserify-inline-fs.js'); |
There was a problem hiding this comment.
Eh, it's harmless left alone. I'd like to defer to brendan on this file. He (or perhaps just I) would like to extract this into its own published package eventually
adamraine
approved these changes
Nov 23, 2021
https://gist.github.com/connorjclark/afd2641c08d6745d8856b1604756e963 good bye 22kb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything* has now been migrated to rollup
So long!
* well, except for a usage in legacy-javascript test harness, will take care of that next