misc(build): set correct exit code when build scripts fail

[connorjclark]

These scripts don't exit with 1 as expected when they fail. They should else they be footguns.

[brendankenny]

These scripts don't exit with 1 as expected when they fail. They should else they be footguns.

FWIW that's only true in Node 14. In Node 15+ unhandled rejections throw and exit with status code 1.

[brendankenny]

'assert/strict' also added in Node 15 :)

[brendankenny]

Y'all could maybe beef up the PR descriptions because it took me a bit of debugging to figure out what was going wrong for me is apparently what is being fixed here :P

This is from yarn build-smokehouse-bundle failing on polyfilling assert.strict, but we only yarn build-all in ci.yml, which is Node 14 only, so the action wasn't failing?

Ideally we could get their polyfill updated if we're going to keep using it (even browserify's polyfill has strict), but for now we could switch to just assert but manually use assert.strictEqual and assert.deepStrictEqual instead of assert.equal and assert.deepEqual. Not a huge deal.

[connorjclark]

This is from yarn build-smokehouse-bundle failing on polyfilling assert.strict

yup

but we only yarn build-all in ci.yml, which is Node 14 only, so the action wasn't failing?

The GH action wasn't (because of wrong exit codes), correct. The import into google3 (see import_tool) was spitting out errors while bundling smokehouse but still chugging along.

[brendankenny]

Hmm, this doesn't appear to fix the yarn build-all exit code problem. See the CI/basics log before the assert/strict change. The error shows up correctly on the subcommand (error Command failed with exit code 1) but the overall build-all script still exits with 0 and so the CI check passes.

This matches what happens locally for me in Node 16 (where unhandled rejections throw so build-smokehouse-bundle fails but the overall build-all is good).

Is it the build-all script? & wait or whatever eating errors?

lighthouse/package.json

Line 17 in a6bcbf2

"build-all:task": "yarn build-report && yarn build-cdt-lib && yarn build-devtools && (yarn build-extension & yarn build-lr & yarn build-viewer & yarn build-treemap & yarn build-smokehouse-bundle & wait) && yarn build-pack",

[connorjclark]

Is it the build-all script? & wait or whatever eating errors?

yup

[connorjclark]

should we just add concurrently from npm?