-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update various devDeps #13485
deps: update various devDeps #13485
Conversation
paulirish
commented
Dec 10, 2021
- we havent needed conventional-changelog-cli for years
- we havent used types/chrome since sendCommand typing got its megaupgrade
- cpy by sindre is safe and happy
@@ -140,8 +139,7 @@ | |||
"c8": "^7.4.0", | |||
"chalk": "^2.4.1", | |||
"chrome-devtools-frontend": "1.0.922924", | |||
"conventional-changelog-cli": "^1.3.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't we use it here?
yarn changelog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh damn. okay yes.
okay instead i updated it to latest. also tested that it still works well.
…ype-aware." This reverts commit 373e716.
build/build-extension.js
Outdated
@@ -53,7 +53,7 @@ async function buildEntryPoint() { | |||
} | |||
|
|||
/** | |||
* @return {Promise<void>} | |||
* @return {Promise<string[]>} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove return?