Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: remove update-notifier #13588

Merged
merged 2 commits into from
Jan 26, 2022
Merged

cli: remove update-notifier #13588

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0c07cb
cli: remove update-notifier
paulirish Jan 24, 2022
fb23f96
rm this too
paulirish Jan 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions lighthouse-cli/bin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ import url from 'url';
import module from 'module';

import log from 'lighthouse-logger';
import updateNotifier from 'update-notifier';

import * as commands from './commands/commands.js';
import * as Printer from './printer.js';
Expand All @@ -51,9 +50,6 @@ function isDev() {
* @return {Promise<LH.RunnerResult|void>}
*/
async function begin() {
// Tell user if there's a newer version of LH.
updateNotifier({pkg}).notify();

const cliFlags = getFlags();

// Process terminating command
Expand Down
5 changes: 0 additions & 5 deletions lighthouse-cli/test/cli/bin-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,6 @@ jest.unstable_mockModule('lighthouse-logger', () => {
return {default: {setLevel: mockLoggerSetLevel}};
});

const mockNotify = jest.fn();
jest.unstable_mockModule('update-notifier', () => {
return {default: () => ({notify: mockNotify})};
});

/** @type {import('../../bin.js')} */
let bin;
beforeAll(async () => {
Expand Down
2 changes: 0 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@
"@types/resize-observer-browser": "^0.1.1",
"@types/semver": "^5.5.0",
"@types/tabulator-tables": "^4.9.1",
"@types/update-notifier": "^4.1.0",
"@types/ws": "^7.0.0",
"@types/yargs": "^16.0.0",
"@types/yargs-parser": "^15.0.0",
Expand Down Expand Up @@ -210,7 +209,6 @@
"semver": "^5.3.0",
"speedline-core": "^1.4.3",
"third-party-web": "^0.12.7",
"update-notifier": "^4.1.0",
"ws": "^7.0.0",
"yargs": "^16.1.1",
"yargs-parser": "^20.2.4"
Expand Down
Loading