tests(smoke): test array _includes and lhr.timing
#13619
Conversation
| @@ -64,11 +64,14 @@ Individual elements of an array can be asserted by using numeric properties in a | |||
|
|
|||
| However, if an array literal is used as the expectation, an extra condition is enforced that the actual array _must_ have the same length as the provided expected array. | |||
|
|
|||
| Arrays can be checked against a subset of elements using the special `_includes` property. The value of `_includes` _must_ be an array. | |||
There was a problem hiding this comment.
What did you think of naming this _subarray or _subset? For example, if another _ helper were added that didn't exclude items as it checked each item, what would the two helpers be named to distinguish them from each other?
should add a note that each assertion in _include will exclude the matching item from consideration in the rest, perhaps with an example showing that
There was a problem hiding this comment.
if another _ helper were added that didn't exclude items as it checked each item, what would the two helpers be named to distinguish them from each other?
I'm ok with _subset, but I can't think of a situation where I would use a helper that doesn't exclude as it goes.
There was a problem hiding this comment.
OK. let's just use _includes for now then.
Landing the smoke test changes separate from #13569.