core: always use MainResource for main document
#13756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
commented
Mar 17, 2022
| @@ -394,6 +394,8 @@ class PageDependencyGraph { | |||
| const networkNodeOutput = PageDependencyGraph.getNetworkNodeOutput(networkRecords); | |||
| const cpuNodes = PageDependencyGraph.getCPUNodes(processedTrace); | |||
|
|
|||
| // TODO: Remove this usage of `findMainDocument`. This assumption isn't true if there was a JS redirect. | |||
| // ... | |||
There was a problem hiding this comment.
This file seems to depend mainDocumentRequest actually being the "first document request" in the case of a JS redirect. It might require a larger refactor in a different PR to eliminate the usage of NetworkAnalyzer.findMainDocument here.
adamraine
commented
Mar 18, 2022
| @@ -7,11 +7,10 @@ | |||
|
|
|||
| /** | |||
| * @param {LH.Artifacts.NetworkRequest[]} networkRecords | |||
| * @param {LH.Artifacts.Script|undefined} script | |||
connorjclark
approved these changes
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to use the
MainResourcecomputed artifact universally instead of callingNetworkAnalyzer.findMainDocumentdirectly. There are two reasons we would want to do this:NetworkAnalyzer.findMainDocument. If we useMainResourceuniversally, we will only need to assert the main document URL exists withinMainResource.NetworkAnalyzer.findMainDocumentwill return the first document request if it is not given a URL as its second parameter. This will return an incorrect network request if there was a JS redirect. There are a few places where this can be confusing/problematic. See Improve handling of redirects, navStart #8984.