tests: clean devtools repo in CI #13758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
commented
Mar 18, 2022
| # The only way the folder already exists _and_ there is a cache-miss is | ||
| # if actions/cache@v2 `restore-keys` has provided a partial environment for us. | ||
| # Do the same as for local, but don't clean! That would toss out all the |
There was a problem hiding this comment.
avoiding clean only makes sense if we were doing -x. but without that flag git will not touch the ignored folders it knows about, which is where the build artifacts are.
connorjclark
commented
Mar 18, 2022
| @@ -24,12 +24,11 @@ then | |||
| git pull --ff-only -f origin main | |||
There was a problem hiding this comment.
i know these two branches are the same but I don't care. do you really want to read a compound bash logic if? because I don't want to write one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the merge issue we were getting in devtools CI build step.
there was an issue with landing a new test file in devtools repo first
https://github.com/GoogleChrome/lighthouse/runs/5591661464?check_suite_focus=true#step:11:52