Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(smoke): realign byte ranges #13920

Merged
merged 2 commits into from
May 4, 2022
Merged

Conversation

connorjclark
Copy link
Collaborator

@connorjclark connorjclark commented Apr 26, 2022

Values had shifted just enough for failures in LR smokerider.

(reminder: these byte values differ slightly in LR because we use a different version of node, which has different headers, and headers are counted as part of the resource size. see cl/379821904)

also related cl/444678919

@connorjclark connorjclark requested a review from a team as a code owner April 26, 2022 22:01
@connorjclark connorjclark requested review from brendankenny and removed request for a team April 26, 2022 22:01
@connorjclark connorjclark merged commit 9039dbb into master May 4, 2022
@connorjclark connorjclark deleted the misc-smoke-byte-changes branch May 4, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants