Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(fetcher): remove iframe fetcher #13923

Merged
merged 15 commits into from
May 5, 2022
Merged

core(fetcher): remove iframe fetcher #13923

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
f6fdfe7
wip
connorjclark Apr 26, 2022
f1493c1
wip
connorjclark Apr 26, 2022
e2030cf
tests(smoke): realign byte ranges
connorjclark Apr 26, 2022
a57a09a
Merge branch 'misc-smoke-byte-changes' into lr-no-iframe-fetcher
connorjclark Apr 26, 2022
9910784
remove much of it
connorjclark Apr 26, 2022
dd42c4d
update
connorjclark Apr 26, 2022
bab201c
fix
connorjclark Apr 27, 2022
e2fcc60
Merge remote-tracking branch 'origin/master' into lr-no-iframe-fetcher
connorjclark May 4, 2022
2ccde48
fix-webt
connorjclark May 4, 2022
c9f7f87
Merge branch 'fix-webte' into lr-no-iframe-fetcher
connorjclark May 4, 2022
3f686ed
fix
connorjclark May 4, 2022
615f14b
update
connorjclark May 4, 2022
71e649d
update
connorjclark May 4, 2022
b9e3176
fix
connorjclark May 4, 2022
b540a39
fix
connorjclark May 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lighthouse-cli/test/smokehouse/test-definitions/byte-efficiency.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,24 +187,24 @@ const expectations = {
items: [
{
url: 'http://localhost:10200/byte-efficiency/script.js',
wastedBytes: '46481 +/- 100',
wastedBytes: '46555 +/- 100',
wastedPercent: '87 +/- 5',
},
{
// /some-custom-url.js,
url: 'inline: \n function unusedFunction() {\n // Un...',
wastedBytes: '6700 +/- 100',
wastedBytes: '6690 +/- 100',
wastedPercent: '99.6 +/- 0.1',
},
{
url: 'inline: \n // Used block #1\n // FILLER DATA JUS...',
wastedBytes: '6563 +/- 100',
wastedBytes: '6569 +/- 100',
wastedPercent: 100,
},
{
url: 'http://localhost:10200/byte-efficiency/bundle.js',
totalBytes: '13000 +/- 1000',
wastedBytes: '2350 +/- 100',
totalBytes: '12962 +/- 1000',
wastedBytes: '2349 +/- 100',
wastedPercent: '19 +/- 5',
},
],
Expand Down
24 changes: 12 additions & 12 deletions lighthouse-cli/test/smokehouse/test-definitions/perf-budgets.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,13 +65,13 @@ const expectations = {
displayValue: '10 requests • 165 KiB',
details: {
items: [
{resourceType: 'total', requestCount: 10, transferSize: '168000±1000'},
{resourceType: 'font', requestCount: 2, transferSize: '81000±1000'},
{resourceType: 'script', requestCount: 3, transferSize: '55000±1000'},
{resourceType: 'image', requestCount: 2, transferSize: '28000±1000'},
{resourceType: 'document', requestCount: 1, transferSize: '2200±150'},
{resourceType: 'other', requestCount: 1, transferSize: '1030±100'},
{resourceType: 'stylesheet', requestCount: 1, transferSize: '450±100'},
{resourceType: 'total', requestCount: 10, transferSize: '168521±1000'},
{resourceType: 'font', requestCount: 2, transferSize: '81096±1000'},
{resourceType: 'script', requestCount: 3, transferSize: '55170±1000'},
{resourceType: 'image', requestCount: 2, transferSize: '28359±1000'},
{resourceType: 'document', requestCount: 1, transferSize: '2283±150'},
{resourceType: 'other', requestCount: 1, transferSize: '1085±100'},
{resourceType: 'stylesheet', requestCount: 1, transferSize: '528±100'},
{resourceType: 'media', requestCount: 0, transferSize: 0},
{resourceType: 'third-party', requestCount: 0, transferSize: 0},
],
Expand All @@ -85,27 +85,27 @@ const expectations = {
{
resourceType: 'total',
countOverBudget: '2 requests',
sizeOverBudget: '66000±1000',
sizeOverBudget: '66121±1000',
},
{
resourceType: 'script',
countOverBudget: '2 requests',
sizeOverBudget: '25000±1000',
sizeOverBudget: '24450±1000',
},
{
resourceType: 'font',
countOverBudget: undefined,
sizeOverBudget: '4000±500',
sizeOverBudget: '4296±500',
},
{
resourceType: 'document',
countOverBudget: '1 request',
sizeOverBudget: '1250±50',
sizeOverBudget: '1259±50',
},
{
resourceType: 'stylesheet',
countOverBudget: undefined,
sizeOverBudget: '450±100',
sizeOverBudget: '528±100',
},
{
resourceType: 'image',
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/fraggle-rock/gather/driver.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ class Driver {
const session = await this._page.target().createCDPSession();
this._session = this.defaultSession = new ProtocolSession(session);
this._executionContext = new ExecutionContext(this._session);
this._fetcher = new Fetcher(this._session, this._executionContext);
this._fetcher = new Fetcher(this._session);
log.timeEnd(status);
}

Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/gather/driver.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ class Driver {
defaultSession = this;

// eslint-disable-next-line no-invalid-this
fetcher = new Fetcher(this.defaultSession, this.executionContext);
fetcher = new Fetcher(this.defaultSession);

/**
* @param {Connection} connection
Expand Down
Loading