Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(audit): update link for source maps to chrome developer docs #14855

Merged
merged 2 commits into from
Mar 3, 2023
Merged

core(audit): update link for source maps to chrome developer docs #14855

merged 2 commits into from
Mar 3, 2023

Conversation

limhenry
Copy link
Contributor

@limhenry limhenry commented Mar 3, 2023

Summary

Update (dead) link for source maps from developers.google.com to developer.chrome.com

Related Issues/PRs

  • N/A

@limhenry limhenry requested a review from a team as a code owner March 3, 2023 20:19
@limhenry limhenry requested review from adamraine and removed request for a team March 3, 2023 20:19
paulirish
paulirish approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi henry!! thanks very much :)

nice job running the tests and the update-json script first. definitely not common for our first-time contributors! ;)

@limhenry
Copy link
Contributor Author

limhenry commented Mar 3, 2023

nice job running the tests and the update-json script first. definitely not common for our first-time contributors! ;)

all thanks to the very detailed contributor guide! 😃

@devtools-bot devtools-bot merged commit 2a54788 into GoogleChrome:main Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulirish paulirish paulirish approved these changes

@adamraine adamraine Awaiting requested review from adamraine adamraine is a code owner automatically assigned from GoogleChrome/lighthouse-hackers

Assignees

@adamraine adamraine

Labels
waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@limhenry @paulirish @adamraine @devtools-bot