Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(smoke): add expectation for lcp-element #15112

Merged
merged 1 commit into from
May 24, 2023
Merged

Conversation

connorjclark
Copy link
Collaborator

Smokerider did not catch the error from #15075 because we have no smoke tests that check largest-contentful-paint-element with simulated throttling.

@connorjclark connorjclark requested a review from a team as a code owner May 24, 2023 21:50
@connorjclark connorjclark requested review from brendankenny and removed request for a team May 24, 2023 21:50
@adamraine
Copy link
Member

Wouldn't the TTFB error be caught here:

'metrics': {
// Flaky in DevTools
_excludeRunner: 'devtools',
details: {items: {0: {
timeToFirstByte: '450+/-100',
lcpLoadStart: '7750+/-500',
lcpLoadEnd: '7750+/-500',
}}},
},
},

@connorjclark
Copy link
Collaborator Author

connorjclark commented May 24, 2023

yeah. also tho we aren't running dbw in smokerider yet, until #15111

won't hurt to also add a check for lcp element audit

@connorjclark connorjclark merged commit c68431a into main May 24, 2023
@connorjclark connorjclark deleted the dbw-lcp-element branch May 24, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants