-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests(config): add unit tests from legacy config #15209
Conversation
I'm gonna temporarily skip the |
…ighthouse into legacy-config-test-parity
Codecov is being weird, but it looks like we don't lose any coverage when skipping the legacy config tests (excluding a bunch of stuff in I'm going to unskip the tests, and this should be landable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy we won't be losing this test coverage :)
This PR adds a bunch of test cases I found in the
legacy/config-test.js
that were not present in any of our new test case files:config-test.js
(not legacy)config-helpers-test.js
validation-test.js
filters-test.js
There are some minor missing features from the legacy config, but this PR is only going to address test coverage. The missing features should be addressed in separate PRs. For reference, the missing features are:
#15060