Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): fix chrome-launcher import example #15428

Merged

Conversation

TortitasT
Copy link
Contributor

Summary

This PR fixes the chrome-launcher import in the first example of docs/README.md

This is a bugfix.

The module chrome-launcher doesn't appear to have a default export. You can test this on a blank node project by:

  • Running npm i chrome-launcher
  • Adding "type": "module" to package.json file.
  • Writing import chromeLauncher from 'chrome-launcher'; on an index.js file.
  • Running node index.js

Related Issues/PRs

@TortitasT TortitasT requested a review from a team as a code owner August 31, 2023 12:14
@TortitasT TortitasT requested review from brendankenny and removed request for a team August 31, 2023 12:14
@google-cla
Copy link

google-cla bot commented Aug 31, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@adamraine adamraine merged commit 268e3af into GoogleChrome:main Sep 2, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants