-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc: adopt minimal license headers #15456
Conversation
Looks like smokes are broke, did decreasing the size of the license affect our transfer size expectations? |
* Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. | ||
* @license | ||
* Copyright 2018 Google LLC | ||
* SPDX-License-Identifier: Apache-2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the source file comments is fine, but the bundle is a form of distribution so it should retain the full reference to the license IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
based on my read of the above docs, the minimal header would be fine for a bundle. but... i don't care too much. i'm happy to keep the full text version for this case. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose the "SPDX-License-Identifier" thing there is pretty cut and dry in terms of declaring the license that applies (tho, it's for a robot, not a human). Still, I think it's nice to give the whole shebang for the bundle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol we both thought this was the bundle comment header, but that's something else and less verbose. nvm
yup. 😢 |
nitting on your wording: this PR changes the acknowledgement of the copyright found in source headers, but that's a meaningless change wrt. to actual copyright assignment. Contributors have and will continue to retain their copyrights... and we are just choosing a different valid approach for legalese comment cruft that is within the guidelines set by our employer |
We're allowed to have more minimal license headers.
So, let's!
Also... in #10469 we added an AUTHORS file and changed to 'The Lighthouse Authors'. The policy says:
We haven't added a name to this since the file was established. So I'd prefer we just stick to the basic model (drop the AUTHORS file, tweak copyright assignment). This PR also includes that change.
FYI The diff page is pretty rough on the browser. Spoiler alert.. It's a lot of diffs like this: