clients(extension): always show settings, add psi frontend #15526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PSI runs mobile&desktop at the same time so that makes the device selector redundant for that backend as well right? Also, I think the backend selector with the domains is pretty confusing for new users. Perhaps we could reword to something like:
|
It determines which tab to select initially. |
Done. |
connorjclark
force-pushed
the
ext-2023
branch
from
531831e
to
6b8b246
Compare
adamraine
approved these changes
Oct 27, 2023
connorjclark
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #15400 (all but locale part via this PR)
Instead of replacing w/ PSI frontend and ditching viewer totally, I added a "backend" option and set PSI to default. This way, we can avoid breaking someone's workflow that prefer the Viewer experience to PSI.