Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(inspector-issues): add cookie deprecation issue #15553

Merged
merged 2 commits into from
Oct 19, 2023
Merged

core(inspector-issues): add cookie deprecation issue #15553

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c22c24f
core(inspector-issues): add cookie deprecation issue
adamraine Oct 19, 2023
c85ce8e
fix e2e
adamraine Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/gather/gatherers/inspector-issues.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ class InspectorIssues extends BaseGatherer {
bounceTrackingIssue: [],
clientHintIssue: [],
contentSecurityPolicyIssue: [],
cookieDeprecationMetadataIssue: [],
corsIssue: [],
deprecationIssue: [],
federatedAuthRequestIssue: [],
Expand Down
1 change: 1 addition & 0 deletions core/test/audits/dobetterweb/inspector-issues-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ describe('Has inspector issues audit', () => {
blockedByResponseIssue: [],
clientHintIssue: [],
contentSecurityPolicyIssue: [],
cookieDeprecationMetadataIssue: [],
corsIssue: [],
deprecationIssue: [],
federatedAuthRequestIssue: [],
Expand Down
2 changes: 2 additions & 0 deletions core/test/gather/gatherers/inspector-issues-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,7 @@ describe('getArtifact', () => {
isReportOnly: false,
contentSecurityPolicyViolationType: 'kInlineViolation',
}],
cookieDeprecationMetadataIssue: [],
deprecationIssue: [{
type: 'AuthorizationCoveredByWildcard',
sourceCodeLocation: {
Expand Down Expand Up @@ -304,6 +305,7 @@ describe('getArtifact', () => {
heavyAdIssue: [],
clientHintIssue: [],
contentSecurityPolicyIssue: [],
cookieDeprecationMetadataIssue: [],
deprecationIssue: [],
attributionReportingIssue: [],
corsIssue: [],
Expand Down
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,9 @@
},
"devDependencies": {
"@build-tracker/cli": "^1.0.0-beta.15",
"@formatjs/icu-messageformat-parser": "^2.6.2",
"@esbuild-kit/esm-loader": "^2.1.1",
"@esbuild-plugins/node-modules-polyfill": "^0.1.4",
"@formatjs/icu-messageformat-parser": "^2.6.2",
"@jest/fake-timers": "^28.1.0",
"@testing-library/preact": "^3.1.1",
"@testing-library/preact-hooks": "^1.1.0",
Expand Down Expand Up @@ -185,7 +185,7 @@
"chrome-launcher": "^1.1.0",
"configstore": "^5.0.1",
"csp_evaluator": "1.1.1",
"devtools-protocol": "0.0.1200039",
"devtools-protocol": "0.0.1211954",
"enquirer": "^2.3.6",
"http-link-header": "^1.1.1",
"intl-messageformat": "^10.5.3",
Expand All @@ -209,8 +209,8 @@
"yargs-parser": "^21.0.0"
},
"resolutions": {
"puppeteer/**/devtools-protocol": "0.0.1200039",
"puppeteer-core/**/devtools-protocol": "0.0.1200039"
"puppeteer/**/devtools-protocol": "0.0.1211954",
"puppeteer-core/**/devtools-protocol": "0.0.1211954"
},
"repository": "GoogleChrome/lighthouse",
"keywords": [
Expand Down
1 change: 1 addition & 0 deletions third-party/chromium-synchronization/inspector-issueAdded-types-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ Array [
"bounceTrackingIssueDetails",
"clientHintIssueDetails",
"contentSecurityPolicyIssueDetails",
"cookieDeprecationMetadataIssueDetails",
"cookieIssueDetails",
"corsIssueDetails",
"deprecationIssueDetails",
Expand Down
1 change: 1 addition & 0 deletions types/artifacts.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,6 +579,7 @@ declare module Artifacts {
bounceTrackingIssue: Crdp.Audits.BounceTrackingIssueDetails[];
clientHintIssue: Crdp.Audits.ClientHintIssueDetails[];
contentSecurityPolicyIssue: Crdp.Audits.ContentSecurityPolicyIssueDetails[];
cookieDeprecationMetadataIssue: Crdp.Audits.CookieDeprecationMetadataIssueDetails[],
corsIssue: Crdp.Audits.CorsIssueDetails[];
deprecationIssue: Crdp.Audits.DeprecationIssueDetails[];
federatedAuthRequestIssue: Crdp.Audits.FederatedAuthRequestIssueDetails[],
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2911,10 +2911,10 @@ delayed-stream@~1.0.0:
resolved "https://registry.yarnpkg.com/delayed-stream/-/delayed-stream-1.0.0.tgz#df3ae199acadfb7d440aaae0b29e2272b24ec619"
integrity sha1-3zrhmayt+31ECqrgsp4icrJOxhk=

[email protected], [email protected].1200039:
version "0.0.1200039"
resolved "https://registry.yarnpkg.com/devtools-protocol/-/devtools-protocol-0.0.1200039.tgz#5a546df3edff52e6226abfc26f559e05647c956b"
integrity sha512-ZQCB/hbFmu23fLrR3OX3FEJ56dBHXBO+OrnXBtutZzJmIRWycDb7Yz4aO7BiFF9moUgBS+Xo7+EAWZhZraOUfg==
[email protected], [email protected].1211954:
version "0.0.1211954"
resolved "https://registry.yarnpkg.com/devtools-protocol/-/devtools-protocol-0.0.1211954.tgz#86ea77d011baab619fb096fc426fd8633ad2ef9b"
integrity sha512-f6BRhngr9wpHN8omZOoSaEJFscTL+tjNhmeBqHHC3CZ3K2N75sDeKXZeTkAEkTCcrusDatfwjRRBh0uz4ov/sA==

diff-sequences@^28.0.2:
version "28.0.2"
Expand Down
Loading