Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: increase page hung check from 1s to 5s #15816

Closed
wants to merge 1 commit into from
Closed

core: increase page hung check from 1s to 5s #15816

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/gather/driver/wait-for-condition.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,11 +384,11 @@
*/
async function isPageHung(session) {
try {
session.setNextProtocolTimeout(1000);
session.setNextProtocolTimeout(5000);

Check warning on line 387 in core/gather/driver/wait-for-condition.js

View check run for this annotation

Codecov / codecov/patch

core/gather/driver/wait-for-condition.js#L387 

Added line #L387 was not covered by tests
await session.sendCommand('Runtime.evaluate', {
expression: '"ping"',
returnByValue: true,
timeout: 1000,
timeout: 5000,

Check warning on line 391 in core/gather/driver/wait-for-condition.js

View check run for this annotation

Codecov / codecov/patch

core/gather/driver/wait-for-condition.js#L391 

Added line #L391 was not covered by tests
});

return false;
Expand Down
Loading