core(driver): add verbose logs for wait-for page load components #15818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
adamraine
reviewed
Feb 20, 2024
| @@ -446,6 +446,21 @@ async function waitForFullyLoaded(session, networkMonitor, options) { | |||
| // CPU listener. Resolves when the CPU has been idle for cpuQuietThresholdMs after network idle. | |||
| let resolveOnCPUIdle = waitForNothing(); | |||
|
|
|||
| if (log.isVerbose()) { | |||
There was a problem hiding this comment.
Why is this if clause necessary? Since you're using log.verbose wouldn't these messages get filtered out under normal circumstances anyway?
There was a problem hiding this comment.
I guess, but I'm adding promises, and I wanted a block for all the debugging stuff.
adamraine
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
was useful for debugging issue mentioned in #15816