core(uses-text-compression): ignore percent threshold for large savings #16165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
force-pushed
the
text-compress-rm-10pct
branch
from
9953f4d
to
523576d
Compare
connorjclark
changed the title
adamraine
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 1400 bytes and 10% thresholds came from WPT. #1513 (comment)
The combination of these two served to exclude suggesting that already compressed resources (like image formats such as PNG) should be compressed, since they can just happen to maybe be a couple bytes smaller given extreme cases (like a small image data section and tons of metadata, which typically isn't compressed).
But using a percentage seems wrong to me, since saving 1MB from a 11MB resource (<10%) is something that seems obviously good to do.
So here I'm suggesting only considering the % threshold if the total savings is less than 20kb.