clients(devtools): require third-party-web to be provided #16166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
commented
Aug 24, 2024
| function runLighthouseNavigation(url, {page, ...options}) { | ||
| return navigation(page, url, options); | ||
| } | ||
|
|
There was a problem hiding this comment.
drive by removal of unused exports
copybara-service bot
pushed a commit
to ChromeDevTools/devtools-frontend
that referenced
this pull request
Aug 27, 2024
This is already included via the Lighthouse bundle, but we need this for an insight in RPP. I changed LH to make this library be injected at runtime, and cherry-pick the change here in this CL, so as not to add an additional 40 KB (post-compression) to Chromium. Related LH PR: GoogleChrome/lighthouse#16166 Bug: 352244718 Change-Id: Iafbf8345bedc23038d83723233a55e4f54c4cb05 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5809617 Reviewed-by: Paul Irish <[email protected]> Commit-Queue: Connor Clark <[email protected]>
adamraine
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We just need one copy of this. Otherwise we are adding an extra 40kb to chromium.
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5809617
b/352244718