handle multiple javascript modal prompts #2120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also add a window.confirm to dbw_tester
brendankenny
changed the title
patrickhulce
approved these changes
May 1, 2017
|
@ebidel suggested one in #1939 (comment). Even worse than geolocation or notification prompts, so yeah, we really should :) |
|
while you're here can you add a |
paulirish
approved these changes
May 2, 2017
done |
paulirish
pushed a commit
to paulirish/lighthouse
that referenced
this pull request
May 5, 2017
* warn when a JS dialog is suppressed * add a window.confirm to dbw_tester
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup to #2106. Solution there only closes the first dialog popup, but we want to always close them, including over a page reload per pass (the test site in #1939 must persist your selection somehow because it now works).
Discovered while adding a smoketest that we handle dismissing modal prompts, so PR also includes that :)