-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(readme): Add new related project, lighthouse-github-reporter #6307
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
readme.md
Outdated
@@ -276,6 +276,8 @@ This section details services that have integrated Lighthouse data. If you're wo | |||
## Related Projects | |||
Other awesome open source projects that use Lighthouse. | |||
|
|||
* **[lighthouse-gh-reporter](https://github.com/addyosmani/webpack-lighthouse-plugin)** - give Lighthouse-CI the power of put reports as a comment on your pull requests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe your url is wrong. It's the same url as webpack-lighthouse-plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nitpicks.
readme.md
Outdated
@@ -276,6 +276,8 @@ This section details services that have integrated Lighthouse data. If you're wo | |||
## Related Projects | |||
Other awesome open source projects that use Lighthouse. | |||
|
|||
* **[lighthouse-gh-reporter](https://github.com/addyosmani/webpack-lighthouse-plugin)** - give Lighthouse-CI the power of put reports as a comment on your pull requests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking the history of this file, we add new integrations to the bottom of the list usually. So I'd move this to right under lighthouse4u.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: give Lighthouse-CI the power of put to make reports as a comment on your pull requests in Github.
PR Changes done! Sorry for the typo errors and position mistake! 👍 |
Hello! Why is the CI failing exactly? What I did wrong? |
It's appveyor, no worries it's pretty flaky |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you for your word fixes @brendankenny ! 😸 |
@wardpeet if you're good here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
This PR ads a new related project into Lighthouse called Lighthouse-github-reporter. More info on the issue.
Related Issues/PRs
#6097