Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(driver): recover from rejection on handleJavaScriptDialog #6327

Merged
merged 2 commits into from
Oct 17, 2018
Merged

core(driver): recover from rejection on handleJavaScriptDialog #6327

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7922db3
core(driver): recover from rejection on handleJavaScriptDialog
paulirish Oct 17, 2018
65256ff
and enable after the event
paulirish Oct 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions lighthouse-core/gather/driver.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1196,17 +1196,16 @@ class Driver {
* @return {Promise<void>}
*/
async dismissJavaScriptDialogs() {
await this.sendCommand('Page.enable');

this.on('Page.javascriptDialogOpening', data => {
log.warn('Driver', `${data.type} dialog opened by the page automatically suppressed.`);

// rejection intentionally unhandled
this.sendCommand('Page.handleJavaScriptDialog', {
accept: true,
promptText: 'Lighthouse prompt response',
});
}).catch(err => log.warn('Driver', err));
});

await this.sendCommand('Page.enable');
}
}

Expand Down