Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(config): faster category validation #6445

Merged
merged 3 commits into from
Nov 1, 2018
Merged

core(config): faster category validation #6445

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98ca0b8
core(config): faster category validation
patrickhulce Nov 1, 2018
e1d8180
use full audit
patrickhulce Nov 1, 2018
e03f0ec
move parent
patrickhulce Nov 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lighthouse-core/config/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,18 @@ function validateCategories(categories, audits, groups) {
return;
}

const auditsKeyedById = new Map((audits || []).map(audit =>
/** @type {[string, LH.Config.AuditDefn]} */
([audit.implementation.meta.id, audit])
));

Object.keys(categories).forEach(categoryId => {
categories[categoryId].auditRefs.forEach((auditRef, index) => {
if (!auditRef.id) {
throw new Error(`missing an audit id at ${categoryId}[${index}]`);
}

const audit = audits && audits.find(a => a.implementation.meta.id === auditRef.id);
const audit = auditsKeyedById.get(auditRef.id);
if (!audit) {
throw new Error(`could not find ${auditRef.id} audit for category ${categoryId}`);
}
Expand Down