Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n: add i18n for LighthouseError messages #6457

Merged
merged 27 commits into from
Dec 10, 2018
Merged

i18n: add i18n for LighthouseError messages #6457

merged 27 commits into from
Dec 10, 2018

Commits on Nov 2, 2018

  1. Added i18n for runtime error messages.

    @exterkamp
    exterkamp committed Nov 2, 2018
    Configuration menu
    Copy the full SHA
    d1be64d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into i18n-errors

    @exterkamp
    exterkamp committed Nov 2, 2018
    Configuration menu
    Copy the full SHA
    6799fab View commit details
    Browse the repository at this point in the history

  3. Formatting on substitutes.

    @exterkamp
    exterkamp committed Nov 2, 2018
    Configuration menu
    Copy the full SHA
    3db8628 View commit details
    Browse the repository at this point in the history

  4. Removed redundant 'Method'.

    @exterkamp
    exterkamp committed Nov 2, 2018
    Configuration menu
    Copy the full SHA
    b9c4b4e View commit details
    Browse the repository at this point in the history

  5. All backticks for variable interpolation highlighting

    @exterkamp
    exterkamp committed Nov 2, 2018
    Configuration menu
    Copy the full SHA
    9b6062b View commit details
    Browse the repository at this point in the history

  6. Thanks linter!

    @exterkamp
    exterkamp committed Nov 2, 2018
    Configuration menu
    Copy the full SHA
    b0d369f View commit details
    Browse the repository at this point in the history

  7. Added substitution check to PROTOCOL_TIMEOUT.

    @exterkamp
    exterkamp committed Nov 2, 2018
    Configuration menu
    Copy the full SHA
    1481b08 View commit details
    Browse the repository at this point in the history

  8. Using test-utils toBeDisplayString.

    @exterkamp
    exterkamp committed Nov 2, 2018
    Configuration menu
    Copy the full SHA
    cf8e569 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2018

  1. Added descriptive ICU names from feedback.

    @exterkamp
    exterkamp committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    df29d17 View commit details
    Browse the repository at this point in the history

  2. Added Method back into test for protocol timeout.

    @exterkamp
    exterkamp committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    020056a View commit details
    Browse the repository at this point in the history

  3. Removed unnecessary var.

    @exterkamp
    exterkamp committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    56e3daf View commit details
    Browse the repository at this point in the history

  4. Fixed i18n of errors and added test to make sure it works!

    @exterkamp
    exterkamp committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    e764e2d View commit details
    Browse the repository at this point in the history

  5. Better gather runner test comparison.

    @exterkamp
    exterkamp committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    7a65d02 View commit details
    Browse the repository at this point in the history

  6. Linter caught me slippin'

    @exterkamp
    exterkamp committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    a6cd8bc View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2018

  1. Moved icu args to properties.

    @exterkamp
    exterkamp committed Nov 14, 2018
    Configuration menu
    Copy the full SHA
    02765e4 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2018

  1. Merge branch 'master' into i18n-errors

    @exterkamp
    exterkamp committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    a991732 View commit details
    Browse the repository at this point in the history

  2. Added early exit. Fixed i18n punc. formatting.

    @exterkamp
    exterkamp committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    879c333 View commit details
    Browse the repository at this point in the history

  3. Collected new strings, and fixed sec-msg test.

    @exterkamp
    exterkamp committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    345d3e4 View commit details
    Browse the repository at this point in the history

  4. Formatting fix.

    @exterkamp
    exterkamp committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    9a87b04 View commit details
    Browse the repository at this point in the history

  5. Fixed LR test.

    @exterkamp
    exterkamp committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    9beb615 View commit details
    Browse the repository at this point in the history

  6. Removed backticks, and added localized test.

    @exterkamp
    exterkamp committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    bdfcc4e View commit details
    Browse the repository at this point in the history

  7. I was led astray.

    @exterkamp
    exterkamp committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    c56c83f View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2018

  1. Update lighthouse-core/test/runner-test.js 

    Co-Authored-By: exterkamp <[email protected]>
    @patrickhulce @exterkamp
    patrickhulce and exterkamp authored Nov 29, 2018
    Configuration menu
    Copy the full SHA
    9857760 View commit details
    Browse the repository at this point in the history

  2. Switched up string templates.

    @exterkamp
    exterkamp committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    d1e1943 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'i18n-errors' of github.com:GoogleChrome/lighthouse into… 

    … i18n-errors
    @exterkamp
    exterkamp committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    c6cfb3b View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2018

  1. Apply suggestions from code review 

    Added paulirish's suggestions for i18n strings.

Co-Authored-By: exterkamp <[email protected]>
    @paulirish @exterkamp
    paulirish and exterkamp authored Dec 7, 2018
    Configuration menu
    Copy the full SHA
    14ceeb2 View commit details
    Browse the repository at this point in the history

  2. Updated strings and test.

    @exterkamp
    exterkamp committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    972ddb5 View commit details
    Browse the repository at this point in the history