DBW: Add helpText to report #695
Conversation
|
IMO we should just change this in report generator. I think this is superior to what the default report has. (Green "Yes", red "No") |
|
Happy to do that if I have the 👍. Don't want to spend time on it and then be :( |
|
👍 from me and @brendankenny on changing the default reporter to use check and X |
|
PTAL
|
| Handlebars.registerHelper('getItemValue', value => { | ||
| if (typeof value === 'boolean') { | ||
| return value ? 'Yes' : 'No'; | ||
| return value ? '✔' : '✘'; |
There was a problem hiding this comment.
whoa, never seen this escape.
don't wanna just pass as a literal?
There was a problem hiding this comment.
Gotta love up on those unicodes.
There was a problem hiding this comment.
The formatter I need for the help text/links:
https://cloud.githubusercontent.com/assets/238208/18770973/b9d882ba-80ef-11e6-82e7-58e0812e8323.png
| Handlebars.registerHelper('getItemValue', value => { | ||
| if (typeof value === 'boolean') { | ||
| return value ? 'Yes' : 'No'; | ||
| return value ? '✔' : '✘'; |
There was a problem hiding this comment.
Gotta love up on those unicodes.
|
Or maybe I don't? Is there a formatter that already does that? |
ebidel
force-pushed
the
dbwformatter
branch
from
2ec6b5a
to
e5d0416
Compare
|
upstreamed the
PTAL |
|
I'll take a look at this this morning |
|
sorry, not the morning anymore :) |
|
This is a great PR. Already loving the new looks. |
R: @paulirish @brendankenny @GoogleChrome/lighthouse
Not worth writing tests at this point. Just need something that's less confusing than the current double negatives for failure results: "Site is not using AppCache: No". This also adds help text for each feature and suggestions (with links) on what to use instead.
Current:
Now:
Eventually we should add a custom report instead of style overrides.