Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(mobile-friendly): Remove manual mobile friendly audit #7223

Merged
merged 1 commit into from
Feb 13, 2019

Conversation

mattzeunert
Copy link
Contributor

Summary

Now that tap targets is merged we don't need need the manual mobile friendly check audit any more.

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huzzah! 🎉 🎉

Aside, I wonder what our breaking changes policy should be removing audits...

Personally I think it's ridiculous for anyone to be relying on a manual audit result 😆 but we've had people mistake them for real results in the past so who knows...

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✂️ ✂️

Copy link
Member

@exterkamp exterkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Great side effect from tap-targets! If we land this before #6860 I can merge it in and avoid mobile friendly in that PR all together 😄

@brendankenny
Copy link
Member

since @exterkamp is ok with fixing #6860 again, let's land :)

@brendankenny brendankenny merged commit c8ed757 into master Feb 13, 2019
@brendankenny brendankenny deleted the remove-manual-mobile-friendly-audit branch February 13, 2019 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants