Bump catapult/traceviewer to latest

[paulirish]

This'll allow us to migrate to the shared FMP and TTI calculations

edit: Babel transpiling added to the build script, in order to address rampant use of destructuring. :)

[brendankenny]

(github really needs a per-file PR viewer)

needs LICENSE but otherwise LGTM.

[brendankenny]

I think this file needs to be kept

[brendankenny]

actually, looks like theres some node v4 and v5 issues with lack of strict mode and class/let/const declarations. Maybe we can insert 'use strict'; lines in the converter scripts?

[paulirish]

use strict injected. license restored.

[paulirish]

Failures in node 4 and 5:

/home/travis/build/GoogleChrome/lighthouse/lighthouse-core/third_party/traceviewer-js/value/histogram.js:493
      for (var [stat, option] of this.summaryOptions) {
               ^
SyntaxError: Unexpected token [

ugh. :/

[brendankenny]

yeah, hmm, even with --harmony that won't work in v4 or v5. I don't see much choice except patching random spots until we're all in on node 6 or upstreaming changes where they break older node.

[samccone]

I don't see much choice except patching random spots until we're all in on node 6 or upstreaming changes where they break older node.

we could also compile our code and deliver a bundle before npm publish and test runs.

I can open a CL for this if you find this acceptable

[brendankenny]

we're already running a conversion script for traceviewer. I'd rather just keep whatever we have to do in there

[samccone]

we're already running a conversion script for traceviewer. I'd rather just keep whatever we have to do in there

https://github.com/GoogleChrome/lighthouse/blob/0295887b88eebf6d80146dd5b79ed6f018451d4b/lighthouse-core/scripts/build-traceviewer-module.js

Is more about converting a browser running system to work in node, and less about "compiling" javascript though.

[paulirish]

All good here. @brendankenny PTAL

[brendankenny]

great detective work. LGTM 💯

[paulirish]

For future reference, this PR updated catapult to 4959b8b832af4f0d91cf1b2bc9bed10fbcccad2e