fix tests which were unconditionally passing failed assertions #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
commented
Oct 4, 2016
| debugString: 'Unable to get document body innerText' | ||
| }; | ||
| }); | ||
| .then(result => { |
There was a problem hiding this comment.
just indentation in this file
paulirish
approved these changes
Oct 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a set of tests that weren't testing anything since anything caught by the
assert(false)path was immediately handled by acatch. In most cases I just got rid of thecatchsince most of the gatherers here don't intentionally throw and so any that do should be caught by mocha.No bugs caught here, just making them do what they say on the tin :)