feat(stack-packs): adds links to some wordpress stack strings #8079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
housseindjirdeh
commented
Apr 8, 2019
| 'efficient-animated-content': | ||
| 'Consider uploading your GIF to a service which will then make it available to embed an HTML5 video. Alternatively find a plugin that will automatically convert GIF images into videos upon upload.', | ||
| 'Consider uploading your GIF to a service which will then make it available to embed an HTML5 video.', |
There was a problem hiding this comment.
Could not find a single plugin that automatically converts GIFs to videos, so removed this mention.
housseindjirdeh
changed the title
paulirish
requested changes
Apr 9, 2019
| 'offscreen-images': | ||
| 'Install a WordPress plugin that provides the ability to defer (lazy-load) any offscreen images, or switch to a theme that provides that functionality. Also consider using AMP.', | ||
| 'Install a [WordPress plugin](https://wordpress.org/plugins/search/lazy+load/) that provides the ability to defer (lazy-load) any offscreen images, or switch to a theme that provides that functionality. Also consider using the [AMP plugin](https://wordpress.org/plugins/amp/).', |
There was a problem hiding this comment.
Suggested change
| 'Install a [WordPress plugin](https://wordpress.org/plugins/search/lazy+load/) that provides the ability to defer (lazy-load) any offscreen images, or switch to a theme that provides that functionality. Also consider using the [AMP plugin](https://wordpress.org/plugins/amp/).', | |
| 'Install a [lazy-load WordPress plugin](https://wordpress.org/plugins/search/lazy+load/) that provides the ability to defer any offscreen images, or switch to a theme that provides that functionality. Also consider using [the AMP plugin](https://wordpress.org/plugins/amp/).', |
| @@ -17,28 +17,28 @@ module.exports = { | |||
| 'unused-css-rules': | |||
| 'Consider reducing, or switching, the number of [WordPress plugins](https://wordpress.org/plugins/) loading unused CSS in your page. To identify plugins that are adding extraneous CSS, try running [code coverage](https://developers.google.com/web/updates/2017/04/devtools-release-notes#coverage) in Chrome DevTools. You can identify the theme/plugin responsible from the URL of the stylesheet. Look out for plugins that have many stylesheets in the list which have a lot of red in code coverage. A plugin should only enqueue a stylesheet if it is actually used on the page.', | |||
| 'uses-webp-images': | |||
| 'Consider using a plugin/service that will automatically convert your uploaded images to the optimal formats.', | |||
| 'Consider using a [plugin/service](https://wordpress.org/plugins/search/convert+webp/) that will automatically convert your uploaded images to the optimal formats.', | |||
There was a problem hiding this comment.
Suggested change
| 'Consider using a [plugin/service](https://wordpress.org/plugins/search/convert+webp/) that will automatically convert your uploaded images to the optimal formats.', | |
| 'Consider using a [plugin](https://wordpress.org/plugins/search/convert+webp/) or service that will automatically convert your uploaded images to the optimal formats.', |
| 'uses-optimized-images': | ||
| 'Consider using a WordPress plugin that optimizes your images, automatically serves the required sizes, and serves them from a CDN.', | ||
| 'Consider using a [WordPress plugin](https://wordpress.org/plugins/search/optimize+images/) that optimizes your images, automatically serves the required sizes, and serves them from a CDN.', |
There was a problem hiding this comment.
automatically serves the required sizes
this is the uses-responses-images audit
and serves them from a CDN.
Lighthouse doesn't have strong feeling about the images being served from a CDN, per se. I would remove this bit.
| 'uses-optimized-images': | ||
| 'Consider using a WordPress plugin that optimizes your images, automatically serves the required sizes, and serves them from a CDN.', | ||
| 'Consider using a [WordPress plugin](https://wordpress.org/plugins/search/optimize+images/) that optimizes your images, automatically serves the required sizes, and serves them from a CDN.', |
There was a problem hiding this comment.
Suggested change
| 'Consider using a [WordPress plugin](https://wordpress.org/plugins/search/optimize+images/) that optimizes your images, automatically serves the required sizes, and serves them from a CDN.', | |
| 'Consider using an [image optimization WordPress plugin](https://wordpress.org/plugins/search/optimize+images/) that compresses your images while retaining quality.', |
just a fan of link text being descriptive ;)
| 'unminified-css': | ||
| 'A number of WordPress plugins can speed up your site by concatenating, minifying, and compressing your styles. You may also want to use a build process to do this minification up-front if possible.', | ||
| 'A number of [WordPress plugins](https://wordpress.org/plugins/search/minify+css/) can speed up your site by concatenating, minifying, and compressing your styles. You may also want to use a build process to do this minification up-front if possible.', |
There was a problem hiding this comment.
You may also want to use a build process to do this minification up-front if possible
Is this possible in WP world? In my experience all CSS/JS comes from either the theme or a plugin, and you can't change those assets with a build process.
|
Shane had some comments over in #7243 (review) that apply here. |
exterkamp
reviewed
Apr 9, 2019
| 'unminified-javascript': | ||
| 'A number of WordPress plugins can speed up your site by concatenating, minifying, and compressing your scripts. You may also want to use a build process to do this minification up-front if possible', | ||
| 'A number of [WordPress plugins](https://wordpress.org/plugins/search/minify+javascript/) can speed up your site by concatenating, minifying, and compressing your scripts. You may also want to use a build process to do this minification up-front if possible', |
There was a problem hiding this comment.
Suggested change
| 'A number of [WordPress plugins](https://wordpress.org/plugins/search/minify+javascript/) can speed up your site by concatenating, minifying, and compressing your scripts. You may also want to use a build process to do this minification up-front if possible', | |
| 'A number of [WordPress plugins](https://wordpress.org/plugins/search/minify+javascript/) can speed up your site by concatenating, minifying, and compressing your scripts. You may also want to use a build process to do this minification up-front if possible.', |
There was a problem hiding this comment.
also no hyphen for up front
| 'efficient-animated-content': | ||
| 'Consider uploading your GIF to a service which will then make it available to embed an HTML5 video. Alternatively find a plugin that will automatically convert GIF images into videos upon upload.', | ||
| 'Consider uploading your GIF to a service which will then make it available to embed an HTML5 video.', |
There was a problem hiding this comment.
Suggested change
| 'Consider uploading your GIF to a service which will then make it available to embed an HTML5 video.', | |
| 'Consider uploading your GIF to a service which will make it available to embed as an HTML5 video.', |
brendankenny
reviewed
Apr 9, 2019
| 'uses-text-compression': 'You can enable this in your web server configuration.', | ||
| 'uses-responsive-images': | ||
| 'Upload images directly through the media library to ensure that the required image sizes are available, and then insert them from the media library or use the image widget to ensure the optimal image sizes are used (including those for the responsive breakpoints). Avoid using `Full Size` images unless the dimensions are adequate for their usage. [Learn More](https://codex.wordpress.org/Inserting_Images_into_Posts_and_Pages#Image_Size)', | ||
| 'Upload images directly through the [media library](https://codex.wordpress.org/Media_Library_Screen) to ensure that the required image sizes are available, and then insert them from the media library or use the image widget to ensure the optimal image sizes are used (including those for the responsive breakpoints). Avoid using `Full Size` images unless the dimensions are adequate for their usage. [Learn More](https://codex.wordpress.org/Inserting_Images_into_Posts_and_Pages#Image_Size)', |
There was a problem hiding this comment.
Suggested change
| 'Upload images directly through the [media library](https://codex.wordpress.org/Media_Library_Screen) to ensure that the required image sizes are available, and then insert them from the media library or use the image widget to ensure the optimal image sizes are used (including those for the responsive breakpoints). Avoid using `Full Size` images unless the dimensions are adequate for their usage. [Learn More](https://codex.wordpress.org/Inserting_Images_into_Posts_and_Pages#Image_Size)', | |
| 'Upload images directly through the [media library](https://codex.wordpress.org/Media_Library_Screen) to ensure that the required image sizes are available, and then insert them from the media library or use the image widget to ensure the optimal image sizes are used (including those for the responsive breakpoints). Avoid using `Full Size` images unless the dimensions are adequate for their usage. [Learn More](https://codex.wordpress.org/Inserting_Images_into_Posts_and_Pages#Image_Size).', |
| 'unminified-javascript': | ||
| 'A number of WordPress plugins can speed up your site by concatenating, minifying, and compressing your scripts. You may also want to use a build process to do this minification up-front if possible', | ||
| 'A number of [WordPress plugins](https://wordpress.org/plugins/search/minify+javascript/) can speed up your site by concatenating, minifying, and compressing your scripts. You may also want to use a build process to do this minification up-front if possible', |
There was a problem hiding this comment.
also no hyphen for up front
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds links for search results + more to Wordpress stack pack audits
@wardpeet @paulirish
Related Issues/PRs
#7243