Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce eslint warnings. #831

Merged
merged 1 commit into from
Oct 26, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lighthouse-cli/test/fixtures/offline-ready-sw.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
'use strict';

/* eslint-env worker, serviceworker */
/* eslint max-nested-callbacks: ["error", 5] */

// This service-worker courtesy of googlechrome.github.io/samples/service-worker/basic/index.html

Expand Down
4 changes: 2 additions & 2 deletions lighthouse-core/aggregator/aggregate.js
Original file line number Diff line number Diff line change
Expand Up @@ -163,10 +163,10 @@ class Aggregate {
// to the overall score and add each to the subItems list.
expectedNames.forEach(e => {
/* istanbul ignore if */
// TODO(paullewis): Remove once coming soon audits have landed.
// TODO(paullewis): Remove once coming soon audits have landed
if (item.audits[e].comingSoon) {
subItems.push({
score: '¯\\_(ツ)_/¯', // TODO(samthor): Patch going to Closure, String.raw is badly typed
score: '¯\\_(ツ)_/¯',
name: 'coming-soon',
category: item.audits[e].category,
description: item.audits[e].description,
Expand Down
4 changes: 0 additions & 4 deletions lighthouse-core/audits/time-to-interactive.js
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,6 @@ class TTIMetric extends Audit {
const endOfTraceTime = model.bounds.max;

// TODO: Wait for DOMContentLoadedEndEvent
// TODO: Wait for UA loading indicator to be done

// TODO CHECK these units are the same
const fMPts = timings.fMPfull + timings.navStart;

// look at speedline results for 85% starting at FMP
Expand All @@ -93,7 +90,6 @@ class TTIMetric extends Audit {
});

if (eightyFivePctVC) {
// TODO CHECK these units are the same
visuallyReadyTiming = eightyFivePctVC.getTimeStamp() - timings.navStart;
}
}
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/closure/closure-type-checking.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ gulp.task('js-compile', function() {
'lib/styles-helpers.js',
'aggregator/**/*.js'
])
// TODO: hack to remove `require`s that Closure currently can't resolve.
// Hack to remove `require`s that Closure currently can't resolve.
.pipe(replace('require(\'../lib/web-inspector\').Color.parse;',
'WebInspector.Color.parse;'))
.pipe(replace('require(\'../lib/traces/tracing-processor\');', '/** @type {?} */ (null);'))
Expand Down
2 changes: 2 additions & 0 deletions lighthouse-core/test/formatter/formatters-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
*/
'use strict';

/* eslint max-nested-callbacks: ["error", 5] */

const assert = require('assert');
const walk = require('walk');
const path = require('path');
Expand Down