Ensure HTML is written to disk when outputMode=pretty. #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`outputMode` in this case is derived from the CLI options and ends up being a regular string. Then it's being compared to an enum value, which in Typscript is a number by default. This PR ensures that we compare string against string and correctly write the HTML output to disk.
Would love your input in this :) |
|
👍 thanks for this |
samccone
approved these changes
Oct 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
outputModein this case is derived from the CLI options and ends up being a regular string.Then it's being compared to an enum value, which in Typscript is a number by default.
This PR ensures that we compare string against string and correctly write the HTML output to disk.
Note: there are cleaner ways to deal with enums in TS which I'd be happy to help with, but for now this fixes the issue.