Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navigate to about:blank before driver setup #850

Merged
merged 2 commits into from
Oct 28, 2016
Merged

navigate to about:blank before driver setup #850

merged 2 commits into from
Oct 28, 2016

Conversation

brendankenny
Copy link
Member

this is especially important for the extension, so we aren't still on the site while trying to clear state, turn on mobile emulation (which might trigger the page to do work), etc.

separate commit to fix a typo I missed in #639 that makes the new check throw in the extension :)

Copy link
Contributor

@ebidel ebidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants