report(tables): change table layout to fixed to ensure proper display… #8514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
approved these changes
Apr 22, 2019
There was a problem hiding this comment.
Thanks for the contribution @ahmadalfy!
Tried on the new report CSS too, and seems to fix the long URL issue quite nicely :)
Before
After
exterkamp
approved these changes
Apr 22, 2019
|
Thank you, sorry if I merged to master directly should I create a branch and resubmit the PR? I didn't find that in the contribution guide. |
|
I know @paulirish has looked at the table layouts before... |
|
we're going to wait on this until after the rest of #8185 lands to make table changes |
|
@ahmadalfy thx very much for writing this. I ended up going a bit deeper and sorting this out in #8820 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change table layout to fixed to ensure proper display of all columns
Summary
This is a fix for layout bug in the generated report. Currently when the number of characters in the URLs exceed the allowed space it results in a display that looks like this:
As you can see, the information for "Potential Savings (KB)" is pushed and cannot be displayed. Fixing that by changing the table layout to
fixedfix the issue.