log: force red color on errors, yellow on warnings. #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
force-pushed
the
logrederrors
branch
from
c291e68
to
0e85f11
Compare
ebidel
suggested changes
Oct 31, 2016
| static loggerfn(title) { | ||
| let log = loggersByTitle[title]; | ||
| if (!log) { | ||
| log = loggersByTitle[title] = debug(title); |
There was a problem hiding this comment.
two lines for rock solid clarity
| const EventEmitter = require('events').EventEmitter; | ||
|
|
||
| debugNode.colors = [6, 2, 4, 5]; |
There was a problem hiding this comment.
can you add a comment for what these does. I'm a noob.
| log = loggersByTitle[title] = debug(title); | ||
| // errors with red, warnings with yellow. | ||
| // eslint-disable-next-line no-nested-ternary | ||
| log.color = title.includes('error') ? 1 : title.includes('warn') ? 3 : undefined; |
ebidel
approved these changes
Nov 1, 2016
brendankenny
reviewed
Nov 1, 2016
| if (!loggersByTitle[title]) { | ||
| loggersByTitle[title] = debug(title); | ||
| const log = Log.loggerfn(title); | ||
| return log(...args); |
There was a problem hiding this comment.
what do these return, incidentally?
There was a problem hiding this comment.
undefined. i'll nuke the explicit return
samccone
reviewed
Nov 1, 2016
| loggersByTitle[title] = log; | ||
| // errors with red, warnings with yellow. | ||
| // eslint-disable-next-line no-nested-ternary | ||
| log.color = title.endsWith('error') ? colors.red : |
There was a problem hiding this comment.
nit extract this lookup logic into a named fn.
nit extract error and warn string into named module private consts
There was a problem hiding this comment.
nit extract error and warn string into named module private consts
disagree (maybe if we were exposing Log.ERROR but we have log.error() for that), but that shouldn't be a surprise by this point :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small followup from #835, from @wardpeet's suggestion..
Errors are red, warnings are yellow. And the other logs will never use those colors