core(lightwallet): add budget to sample artifacts config #8783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
commented
May 1, 2019
| @@ -31,7 +50,7 @@ async function update() { | |||
| url, | |||
| ].join(' '); | |||
| const flags = cliFlags.getFlags(rawFlags); | |||
| await cli.runLighthouse(url, flags, undefined); | |||
| await cli.runLighthouse(url, flags, budgetedConfig); | |||
There was a problem hiding this comment.
since we don't run bin.js (which would allow loading from a --budget-path), this could either put a budget on flags.budgets or make a config as it does here. The config seemed cleaner, but I'm not overly attached to the approach.
patrickhulce
approved these changes
May 2, 2019
| @@ -31,7 +50,7 @@ async function update() { | |||
| url, | |||
| ].join(' '); | |||
| const flags = cliFlags.getFlags(rawFlags); | |||
| await cli.runLighthouse(url, flags, undefined); | |||
| await cli.runLighthouse(url, flags, budgetedConfig); | |||
good point :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8427 manually added a budget to the sample artifacts. This PR changes
update-report-fixtures.jsto add a budget to the run so that it will always be in the sample artifacts when it's updated in the future.Originally discussed in #8427 (comment).
I just copied the budget added in #8427. The property order changes in the
artifacts.jsonfile because this is the order thatbudget.jsinitializes things.