report(redesign): design review feedback #8785
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -76,6 +76,7 @@ | |
| --lh-audit-group-vpadding: 8px; | ||
| --lh-section-vpadding: 12px; | ||
| --chevron-size: 12px; | ||
| --inner-audit-left-padding: calc(var(--text-indent) + var(--lh-audit-index-width) + 2 * var(--audit-item-gap)); | ||
|
|
||
| /* Palette. */ | ||
| --color-black-100: #F5F5F5; | ||
|
|
@@ -104,8 +105,8 @@ | |
| --env-name-min-width: 220px; | ||
| --env-tem-padding: 10px 0px; | ||
| --expandable-padding: 0 0 2px calc(var(--score-shape-margin-left) + var(--score-shape-size) + var(--score-shape-margin-right)); | ||
| --gauge-circle-size-big: 112px; | ||
| --gauge-circle-size: 80px; | ||
| --header-padding: 20px 0 20px 0; | ||
| --highlighter-bg: var(--color-black-400); | ||
| --icon-square-size: calc(var(--score-shape-size) * 0.88); | ||
|
|
@@ -115,10 +116,10 @@ | |
| --plugin-icon-size: 65%; | ||
| --pwa-icon-margin: 0 6px 0 -2px; | ||
| --pwa-icon-size: var(--topbar-icon-size); | ||
| --score-container-padding: 8px; | ||
| --score-container-width: 148px; | ||
| --score-number-font-size-big: 38px; | ||
| --score-number-font-size: 28px; | ||
| --score-shape-margin-left: 4px; | ||
| --score-shape-margin-right: 12px; | ||
| --score-shape-margin-top: 7px; | ||
|
|
@@ -132,7 +133,7 @@ | |
| --scorescale-width: 18px; | ||
| --section-padding: 40px; | ||
| --topbar-bg: var(--color-black-100); | ||
| --topbar-height: 32px; | ||
| --topbar-icon-size: 24px; | ||
| --topbar-padding: 0 8px; | ||
|
|
||
|
|
@@ -212,7 +213,6 @@ | |
| --header-padding: 16px 0 16px 0; | ||
| --plugin-icon-size: 75%; | ||
| --pwa-icon-margin: 0 7px 0 -3px; | ||
| --score-container-width: 112px; | ||
| --score-number-font-size-big: 34px; | ||
| --score-number-font-size: 26px; | ||
|
|
@@ -224,7 +224,7 @@ | |
| --score-title-line-height-big: 26px; | ||
| --score-title-line-height: 20px; | ||
| --section-padding: 24px; | ||
| --topbar-height: 28px; | ||
| --topbar-icon-size: 20px; | ||
| } | ||
|
|
||
|
|
@@ -325,7 +325,6 @@ | |
| } | ||
|
|
||
| .lh-audit__description, .lh-audit__stackpack { | ||
| --inner-audit-right-padding: calc(var(--text-indent) + 2px); | ||
| padding-left: var(--inner-audit-left-padding); | ||
| padding-right: var(--inner-audit-right-padding); | ||
|
|
@@ -337,6 +336,7 @@ | |
| font-size: var(--body-font-size); | ||
| margin-top: var(--default-padding); | ||
| margin-bottom: var(--default-padding); | ||
| margin-left: var(--inner-audit-left-padding); | ||
| /* whatever the .lh-details side margins are */ | ||
| width: 100%; | ||
| } | ||
|
|
@@ -471,6 +471,7 @@ | |
| } | ||
| .lh-category-header__description { | ||
| font-size: var(--body-font-size); | ||
| text-align: center; | ||
| margin: 0px auto; | ||
| max-width: 400px; | ||
| } | ||
|
|
@@ -575,7 +576,7 @@ | |
| display: flex; | ||
| flex-wrap: wrap; | ||
| justify-content: space-between; | ||
| padding: 10px var(--text-indent); | ||
| } | ||
|
|
||
| .lh-metric__details { | ||
|
|
@@ -589,7 +590,6 @@ | |
|
|
||
| .lh-metrics__disclaimer { | ||
| color: var(--medium-75-gray); | ||
| margin: var(--lh-section-vpadding) 0; | ||
| padding: 0 var(--text-indent); | ||
| } | ||
|
|
@@ -886,6 +886,10 @@ | |
| /* When the header takes 100% width, the chevron becomes small. */ | ||
| max-width: calc(100% - var(--chevron-size)); | ||
| } | ||
| /* max-width makes the metric toggle not flush. metrics doesn't have a chevron so unset. */ | ||
| .lh-audit-group--metrics .lh-audit-group__header { | ||
| max-width: unset; | ||
| } | ||
|
|
||
| .lh-audit-group__header span.lh-audit-group__title { | ||
| font-weight: bold; | ||
|
|
@@ -968,11 +972,13 @@ | |
|
|
||
| .lh-warnings { | ||
| --item-margin: calc(var(--body-line-height) / 6); | ||
| color: var(--color-average); | ||
| margin: var(--lh-audit-vpadding) 0; | ||
| padding: calc(var(--lh-audit-vpadding) / 2) var(--lh-audit-vpadding); | ||
| } | ||
| .lh-warnings span { | ||
| font-weight: bold; | ||
| } | ||
|
|
||
| .lh-warnings--toplevel { | ||
| --item-margin: calc(var(--header-line-height) / 4); | ||
|
|
@@ -1158,18 +1164,18 @@ | |
| .lh-table { | ||
| --image-preview-size: 24px; | ||
| border-collapse: collapse; | ||
| /* Can't assign padding to table, so shorten the width instead. */ | ||
| width: calc(100% - var(--inner-audit-left-padding)); | ||
| } | ||
|
|
||
| .lh-table thead th { | ||
|
There was a problem hiding this comment. we had something in there about text alignment with headers
right, @yuinchien? There was a problem hiding this comment. hm i aligned it to the description instead There was a problem hiding this comment. @hoten the title, description, the table heading(URL), the table should all align left to the same line.
There was a problem hiding this comment. @hoten can we horizontally center the shape (triangle) with the first line of title? Thanks! |
||
| font-weight: normal; | ||
| color: var(--color-black-600); | ||
| /* See text-wrapping comment on .lh-container. */ | ||
| word-break: normal; | ||
| } | ||
|
|
||
| .lh-table tbody tr:nth-child(odd) { | ||
| background-color: var(--lh-table-higlight-bg); | ||
| } | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was mentioned in the design meeting. @yuinchien asked if the animation could be shorter. i said what if it were just removed completely. i thought everyone said ok
idea was just - user wants to see a particular part of the report, so just show them as soon as intent is made w/o the fanfare of a scroll animation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yuin and i are still attached to it. i got a branch for fixing the highlighter anim
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paulirish whats up with this