misc: fix roundtrip #8815
Merged
misc: fix roundtrip #8815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
node version? |
|
node --version |
|
I get the same w/ v10.14.2 |
|
lgtm me then ? :) |
|
can confirm I get the same diff on 11.13.0 as well |
patrickhulce
reviewed
May 2, 2019
| "title": "Keep request counts low and transfer sizes small" | ||
| }, | ||
| }, |
There was a problem hiding this comment.
this seems...not ideal :) why is adding so many extra spaces and useless .0s?
There was a problem hiding this comment.
I fixed the trailing spaces in #8818, we could try to get rid of the useless .0s, but it's messier...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just ran
yarn update:sample-jsonon master and this is the diff i got.curious if everyone else has the same changes?