Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: bail on gathering if we have a failure in the first pass #8866

Closed
wants to merge 3 commits into from

Conversation

paulirish
Copy link
Member

While working on #8865 I noticed the offline pass is troublesome for security interstitial cases. This would help us fail the whole run quickly if we have a pageLoadError when loading the original URL.

In essence: if we can't load the provided URL, we shouldn't try to load it offline and we shouldn't try to see if the http redirect works.

There's a few ways of doing this, but I went for the dumb and straightforward way. :)

@paulirish
Copy link
Member Author

@patrickhulce i wrote this before reading #8340 ... seeing that we want both... what do you think makes sense?

@patrickhulce
Copy link
Collaborator

Doing both this and #8340 makes sense to me 👍

The only part about this I don't love is that the audits in those other passes will now fail with "required artifact Blah missing" instead of the load error, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants