core: bail on gathering if we have a failure in the first pass #8866
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #8865 I noticed the offline pass is troublesome for security interstitial cases. This would help us fail the whole run quickly if we have a pageLoadError when loading the original URL.
In essence: if we can't load the provided URL, we shouldn't try to load it offline and we shouldn't try to see if the http redirect works.
There's a few ways of doing this, but I went for the dumb and straightforward way. :)